Conversation
pyproject.toml
Outdated
| "scippnexus>=25.06.0", | ||
| # Numba has an upper pin and pip-compile-multi will | ||
| # always complain about solving envs with different numpy pins. | ||
| "numpy<2.4", |
There was a problem hiding this comment.
We should not have upper pins in the main dependencies.
We should try to find a different way of solving this issue.
Numba is not a core dependency, but is needed for the tests.
We could e.g. add the pin to the tests deps, instead of the main deps, or add a pin in the test.in file?
There was a problem hiding this comment.
I agree I don't like this setup either.
The problem is that pip-compile-multi does not care about the pyproject.toml file, it is solving envs from the requirements folder.
I can add this to base.in, but this adds another place to bump deps manually which I don't like much. But anyway pushed a new commit which should move the numpy pin out of pyproject.toml
| "matplotlib>=3.10.7", | ||
| "numba>=0.59", | ||
| "pooch>=1.5", | ||
| "numba>=0.63", |
There was a problem hiding this comment.
Not that it is harmful, but why do we need this minimum version of numba?
Seems unrelated to the linked issue which is about pooch?
There was a problem hiding this comment.
numba has upper pins on numpy and numba 0.63 supports python 3.14
numba 0.59 has upper pin on 1.27
numba 0.60 has upper pin on 2.1
numba 0.61 has upper pin on 2.2
....
So we would need to bump numba to atleast 0.60 anyway to have some sane resolution with pip compile multi
2 participants
This should fix #289 too.